Skip to content

fix printing of DEStats #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2025
Merged

fix printing of DEStats #1068

merged 1 commit into from
Jul 19, 2025

Conversation

@ranocha
Copy link
Member

@ranocha ranocha commented Jul 18, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Before this PR:

julia> SciMLBase.DEStats()
SciMLBase.DEStats
Number of function 1 evaluations:                  -1
Number of function 2 evaluations:                  -1
Number of W matrix evaluations:                    -1
Number of linear solves:                           -1
Number of Jacobians created:                       -1
Number of nonlinear solver iterations:             -1
Number of nonlinear solver convergence failures:   -1
Number of fixed-point solver iterations:                     -1
Number of fixed-point solver convergence failures:           -1
Number of rootfind condition calls:                -1
Number of accepted steps:                          -1
Number of rejected steps:                          -1

With this PR:

julia> SciMLBase.DEStats()
SciMLBase.DEStats
Number of function 1 evaluations:                  -1
Number of function 2 evaluations:                  -1
Number of W matrix evaluations:                    -1
Number of linear solves:                           -1
Number of Jacobians created:                       -1
Number of nonlinear solver iterations:             -1
Number of nonlinear solver convergence failures:   -1
Number of fixed-point solver iterations:           -1
Number of fixed-point solver convergence failures: -1
Number of rootfind condition calls:                -1
Number of accepted steps:                          -1
Number of rejected steps:                          -1

@ChrisRackauckas ChrisRackauckas merged commit 21a3c64 into SciML:master Jul 19, 2025
56 of 64 checks passed
@ranocha ranocha deleted the hr/fix_stats_printing branch July 19, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oscardssmith oscardssmith oscardssmith approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ranocha @oscardssmith @ChrisRackauckas